#907 Add vertically centered fold tail markers

Completed
closed
Scintilla (357)
5
2012-03-08
2012-02-16
No

Attached is a patch that adds vertically centered fold tail markers. This way you can choose markers that are symmetrical to the fold header markers, which are drawn centered.

Current fold tail markers are not positioned at the center when line height is larger than fold margin width, which can look odd since in that case tail will be drawn in the upper part of the line.

Discussion

  • Neil Hodgson

    Neil Hodgson - 2012-02-16

    I doubt there was an intention for the original outline markers not to be centred vertically.

     
  • Neil Hodgson

    Neil Hodgson - 2012-02-16
    • assigned_to: nobody --> nyamatongwe
     
  • Marko Njezic

    Marko Njezic - 2012-02-16

    I wanted to change existing markers, but as I could not determine if current positioning was intentional, I opted to create separate markers. However, if it is ok with you, I can create a different patch that changes existing markers instead.

    And while we're on this subject, is there a reason why square tail marker is drawn 2px from the right, while curved is drawn just 1px from the right? Can the square tail marker be changed so it is drawn 1px from the right like curved one?

     
  • Marko Njezic

    Marko Njezic - 2012-02-17

    Patch that changes existing markers

     
  • Marko Njezic

    Marko Njezic - 2012-02-17

    I've attached a new patch that changes existing markers, so they are centered vertically. The width of square tail marker has also been changed so it is the same as the width of curved one.

     
  • Neil Hodgson

    Neil Hodgson - 2012-02-18

    IIRC, the initial square tails were chosen to be less prominent. The curved tails were then extended as they looked incomplete in normal sizes.

    Committed.

     
  • Neil Hodgson

    Neil Hodgson - 2012-02-18
    • milestone: --> Completed
     
  • Neil Hodgson

    Neil Hodgson - 2012-03-08
    • status: open --> closed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks