Menu

#1454 Set change history when save point is reached

Won't_Implement
closed
scintilla (299)
5
2023-01-29
2022-09-27
Zufu Liu
No

As enable change history has no effect when there are undo history, it seems better to auto enable it after save point is reached.
single line addition in Editor::NotifySavePoint(bool isSavePoint):

if (changeHistoryOption != ChangeHistoryOption::Disabled) {
    pdoc->ChangeHistorySet(FlagSet(changeHistoryOption, ChangeHistoryOption::Enabled));
    Redraw();
}

Discussion

  • Neil Hodgson

    Neil Hodgson - 2022-09-27

    The benefit is unclear - it seems to just relax the order of calls slightly.

     
  • Zufu Liu

    Zufu Liu - 2022-09-27

    If not set here, application that allows enable/disable change history will need to set it in SCN_SAVEPOINTREACHED.

     
  • Neil Hodgson

    Neil Hodgson - 2022-09-27

    But it won't work in general for SCN_SAVEPOINTREACHED only at the point undo is enabled so why wouldn't the application enable change history when enabling undo?

     
  • Neil Hodgson

    Neil Hodgson - 2022-10-11
    • Group: Initial --> Won't_Implement
     
  • Neil Hodgson

    Neil Hodgson - 2022-10-11

    I'm not understanding the point of this change so won't be including it.

     
  • Neil Hodgson

    Neil Hodgson - 2023-01-29
    • status: open --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB