Menu

#2509 Fortran folding update

Bug
open
nobody
5
4 days ago
5 days ago
darmar
No

Fortran 2023 added "enumeration type" and "change team" constructs. Folding for these constructs is not correct in Scintilla. I prepared a small patch which corrects this.

Examples:

ENUMERATION TYPE :: v_value
    Enumerator :: v_one, v_two, v_three
    Enumerator v_four
END ENUMERATION TYPE

CHANGE TEAM (NEW_TEAM)
    !
    A [1] = 9.0
END TEAM
1 Attachments

Discussion

  • Neil Hodgson

    Neil Hodgson - 4 days ago

    You sent a patch for change team folding in 2018 which was committed and appears to work.
    https://github.com/ScintillaOrg/lexilla/commit/cbe9a57c8b178aaf13069df1f272078bae9bd268

    The new patch seems to duplicate the purpose of the previous patch. Maybe the previous change team code should be removed?

    Lexilla is now a separate project and is maintained on GitHub as https://github.com/ScintillaOrg/lexilla . It is better for patches to be sent there as that is where the community expects them and it helps maintain the links between issues and changes. The other issue [#2508] is fine here as SciTE hasn't moved to GitHub.

    There's also a testing framework (see lexilla/test/README) where example text files are stored and checked to make sure fixes stay fixed. So add a test case file to lexilla/test/examples/fortran with the new constructs.

     

    Related

    Bugs: #2508

  • darmar

    darmar - 4 days ago

    You are right about duplicate. Somehow I managed to overlook this.
    I will send updated patch to Lexille on github.

     

Log in to post a comment.

MongoDB Logo MongoDB