#2482 Autocomplete list in 5.5.6 (Windows)

[Sven]

There are two issues with the new autocompletion lists in 5.5.6.

1) ColourElement returns a wrong value when colour is RGB(0, 0, 0). The result is RGBA(0, 0, 0, 0), which results in an incorrect display.

Proposed fix:

if (colour.has_value()) {
// return colour.value();
  return ColourRGBA::FromRGB(colour.value().OpaqueRGB());

2) ListBoxX::AllocateBitMap() should use the ItemHeight() to initialize the bitmap. With the currently used lineHeight, the bitmap is smaller than the item, and using a custom background color results in unsightly dividers.

Proposed fix:

//  const SIZE extent { GetClientExtent().x, lineHeight };
    const SIZE extent { GetClientExtent().x, ItemHeight() };

[Neil Hodgson]

Committed but with simpler expression for ColourElement.

[Sven]

Much simpler. Thanks!