#2313 read.only.indicator "|" not displayed when file opened with -read.only argument

[j-camp]

If I open a file from the command line using:
$ scite -read.only -read.only.indicator test.txt
the file is opened read only, but the read only indicator "|" is not shown on the file tab and is not shown in the buffers menu.

If I click the Options menu and uncheck "Read Only", and then go back and recheck "Read Only", now the read only indicator is shown on the file tab and in the buffers menu, but is still not displayed in the header bar. Ideally it should be visible in the header bar, too.

I am using SciTE v5.1.6 on GTK 3.24.31 on Arch Linux. I am using all default options, I haven't set any user preferences.

[Neil Hodgson]

isReadOnly is set in SciTEBase::Open after the tabs have been named with SetBuffersMenu. Moving SetBuffersMenu to after setting isReadOnly seems to work.

Its too late to include this in the next release.

[j-camp]

2313.patch works.

I created an additional patch to show the read-only indicator in the window name the same as how it's shown in the buffers menu (see attached file)

[Neil Hodgson]

This also changes behaviour when read-only not involved: '-' always appears including when file changed instead of being replaced by '*'.

[j-camp]

Attached is an updated patch with your suggested change.

[Neil Hodgson]

Committed with [cedcb1].

[Neil Hodgson]

Committed fix as [5b4aa2].