Menu

#2110 Scintilla on Win32 does not use wParam on WM_GETTEXT

Bug
closed-fixed
5
2019-07-05
2019-06-14
No

The Win32 message WM_GETTEXT takes maximum length and string (wchar_t*) arguments. Scintilla's implementation ignores the length argument.

When the length is shorter than needed for all of the text, this leads to exceptions within Scintilla which are translated to a bad status and failure to set the string result. This can cause application crashes. For example, when the NVDA screen reader requests some of the text from SciTE, SciTE may crash.

Attached is a potential fix along with tests.

1 Attachments

Related

Bugs: #2114

Discussion

  • Neil Hodgson

    Neil Hodgson - 2019-06-15
    • status: open --> open-fixed
     
  • Neil Hodgson

    Neil Hodgson - 2019-06-15

    Fixed with [d7aeda].

     

    Related

    Commit: [d7aeda]

  • Neil Hodgson

    Neil Hodgson - 2019-07-05
    • status: open-fixed --> closed-fixed
     
  • Neil Hodgson

    Neil Hodgson - 2019-07-05

    Fixed with [d7aeda].

     

    Related

    Commit: [d7aeda]


Log in to post a comment.

MongoDB Logo MongoDB