#1905 Stream Selection Mode Regression

[active-m]

Hi, I think changeset 5569:1471538e8636 introduced a regression in stream selection mode (SELECTIONMODE = SEL_STREAM). When moving the caret up or down, the selection is discarded instead of extended up/down. However, when moving the caret left or right, the selection extends as expected.

[Neil Hodgson]

The change set referenced is [147153].

Try this change:

diff -r d718fc162911 src/Editor.cxx
--- a/src/Editor.cxx    Thu Feb 02 10:20:30 2017 +1100
+++ b/src/Editor.cxx    Fri Feb 03 09:06:12 2017 +1100
@@ -3111,6 +3111,9 @@
 }

 void Editor::CursorUpOrDown(int direction, Selection::selTypes selt) {
+   if ((selt == Selection::noSel) && sel.MoveExtends()) {
+       selt = Selection::selStream;
+   }
    SelectionPosition caretToUse = sel.Range(sel.Main()).caret;
    if (sel.IsRectangular()) {
        if (selt ==  Selection::noSel) {

[active-m]

Confirmed that that patch fixes the regression. Thank you!

[Neil Hodgson]

Committed as [7f2289].