Menu

#1862 SciTE: CFLAGS/CXXFLAGS usage

Bug
closed-fixed
5
2016-10-16
2016-09-15
No

There are two minor issues in SciTE gtk/makefile:

  1. CFLAGS used too early:

    .c.o:
    $(CC) $(CFLAGS) $(INCLUDEDIRS) $(MISLEADING) -DLUA_USE_POSIX $(CXXTFLAGS) -c $< -o $@

User-defined CFLAGS should be in the end of the list:

.c.o:
        $(CC) $(INCLUDEDIRS) $(MISLEADING) -DLUA_USE_POSIX $(CXXTFLAGS) $(CFLAGS) -c $< -o $@

to let user (e. g. distro packager) override makefile-provided flags.

  1. CXXFLAGS is not used:

    deps.mak:
    $(CXX) -MM $(CONFIGFLAGS) $(CXXTFLAGS) $(srcdir)/.cxx $(srcdir)/../src/.cxx | sed -e 's/\/usr.* //' | grep [a-zA-Z] >$@

I would expect $(CXXFLAGS) just after $(CXXTFLAGS):

deps.mak:
        $(CXX) -MM $(CONFIGFLAGS) $(CXXTFLAGS) $(CXXFLAGS) $(srcdir)/*.cxx $(srcdir)/../src/*.cxx | sed -e 's/\/usr.* //' | grep [a-zA-Z] >$@
1 Attachments

Discussion

  • Neil Hodgson

    Neil Hodgson - 2016-09-17
    • labels: --> scite, build
    • status: open --> open-fixed
    • assigned_to: Neil Hodgson
     
  • Neil Hodgson

    Neil Hodgson - 2016-09-17

    Committed as [bb3528].

     

    Related

    Commit: [bb3528]

  • Neil Hodgson

    Neil Hodgson - 2016-10-16
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.