#1854 Unintended input conversion before matching keymap

Bug
closed-fixed
5
2016-09-05
2016-08-25
Tse Kit Yam
No

In a key down event of Mac, input character with modifier may be converted to a new character, and it may not match what we defined in the key map.

e.g.
Control + k => char with Ascii code 11
As a result, this input combination will not match {'k', SCI_META, SCI_DELLINERIGHT}, but {11, SCI_META, SCI_DELLINERIGHT}

I suggested that we should use -[NSEvent charactersIgnoringModifiers] to get the input, instead of -[NSEvent characters] to avoid this unintended conversion

Discussion

  • Tse Kit Yam

    Tse Kit Yam - 2016-08-25

    Here is my proposed changes

     
    • Neil Hodgson

      Neil Hodgson - 2016-08-25

      Seems OK in limited testing. I'll wait to see if others have opinions.

       
  • Neil Hodgson

    Neil Hodgson - 2016-08-25
    • labels: --> scintilla, cocoa, keyboard
    • status: open --> open-accepted
    • assigned_to: Neil Hodgson
     
  • Neil Hodgson

    Neil Hodgson - 2016-08-29
    • status: open-accepted --> open-fixed
     
  • Neil Hodgson

    Neil Hodgson - 2016-09-05
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks