#1844 Scintilla: CFLAGS usage in gtk/makefile is not fully correct.

[Van de Bugger]

gtk/makefile collects Scintilla-specific C++ compiler options in CXXTFLAGS make variable, and leaves CXXFLAGS variable for user, so user can specify user-specific C++ compiler options in make command line, e. g.:

$ make CXXFLAGS="..."

It is correctly implemented by following gtk/makefile lines:

.cxx.o:
        $(CXX) $(CONFIGFLAGS) $(CXXTFLAGS) $(CXXFLAGS) -c $<

However, it is not true for C compiler options. If user specify CFLAGS variable in make command line, e. g.:

$ make CFLAGS="..."

it will destroy all Scintilla-specific C compiler options due to incorrect gtk/makefile code:

CFLAGS:=$(CTFLAGS)

.c.o:
        $(CC) $(CONFIGFLAGS) $(CFLAGS) -w -c $<

Correct code:

.c.o:
        $(CC) $(CONFIGFLAGS) $(CTFLAGS) $(CFLAGS) -w -c $<

See the attached patch.

[Neil Hodgson]

Committed as [8f2d31]. Please tell me if you want a name different to Van de Bugger in the change log.