#1844 Scintilla: CFLAGS usage in gtk/makefile is not fully correct.

Bug
closed-fixed
5
2016-09-05
2016-07-04
No

gtk/makefile collects Scintilla-specific C++ compiler options in CXXTFLAGS make variable, and leaves CXXFLAGS variable for user, so user can specify user-specific C++ compiler options in make command line, e. g.:

$ make CXXFLAGS="..."

It is correctly implemented by following gtk/makefile lines:

.cxx.o:
        $(CXX) $(CONFIGFLAGS) $(CXXTFLAGS) $(CXXFLAGS) -c $<

However, it is not true for C compiler options. If user specify CFLAGS variable in make command line, e. g.:

$ make CFLAGS="..."

it will destroy all Scintilla-specific C compiler options due to incorrect gtk/makefile code:

CFLAGS:=$(CTFLAGS)

.c.o:
        $(CC) $(CONFIGFLAGS) $(CFLAGS) -w -c $<

Correct code:

.c.o:
        $(CC) $(CONFIGFLAGS) $(CTFLAGS) $(CFLAGS) -w -c $<

See the attached patch.

1 Attachments

Discussion

  • Neil Hodgson

    Neil Hodgson - 2016-08-11
    • labels: --> scintilla, gtk
    • status: open --> open-fixed
    • assigned_to: Neil Hodgson
     
  • Neil Hodgson

    Neil Hodgson - 2016-08-11

    Committed as [8f2d31]. Please tell me if you want a name different to Van de Bugger in the change log.

     

    Related

    Commit: [8f2d31]

  • Neil Hodgson

    Neil Hodgson - 2016-09-05
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks