ctrl-click folding regression after fix for bug #1799

Brought to you by: antoniolinares, johnsoonj, kapix93, nyamatongwe, and 2 others

#1842 ctrl-click folding regression after fix for bug #1799

Milestone: Bug

Status: closed-fixed

Owner: Neil Hodgson

Labels: folding (15) scintilla (610) scite (198)

Priority: 5

Updated: 2016-09-05

Created: 2016-06-24

Creator: Oliver Yeoh

Private: No

Since bug #1799 was fixed, ctrl-click doesn't always work as expected
Have confirmed this by removing the commits for #1799

Unfortunately I don't know how to fix this. Hopefully this information helps.

Have attached a test file and also a screenshot of the problem

open test.c
ctrl-click on a()
ctrl-click on b()
problem: b() doesn't fold

2 Attachments

screenshot.png

test.c

Discussion

Neil Hodgson - 2016-08-15

labels: folding --> folding, scintilla, scite

status: open --> open-fixed

assigned_to: Neil Hodgson
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Neil Hodgson - 2016-08-15

The problem appears to be that the text offscreen hadn't been lexed or had fold structure extracted (or this information was stale) which then caused styling which led to recursive execution of folding code. Avoided by finding last child text, and thus styling, before folding the line.

Fommitted as [4ce6fa] for SciTE and as [91d90d] for the similar code in Scintilla.

Related

Commit: [4ce6fa]
Commit: [91d90d]

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Neil Hodgson - 2016-09-05

status: open-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.