Menu

#1596 Scintilla __WX__ define supersedes all other platforms in wxWidgets

Bug
closed-rejected
3
2014-05-22
2014-05-02
DW8Reaper
No

I am building scintilla as part of wxWidgets and noticed that shortcut keys on OSX do not function correctly. The problem seems to be that the define for __WX__ in Platform.h is always set so PLAT_MACOSX never gets set.

I couldn't find any details on how to supply a patch so I have attached an svn diff file I originally sent to the wxWidgets project that shows the changes I made there. Since I am not sure what the intended use of __WX__ is I don't know if what I have done is correct but I suspect it is incorrectly set since when building wxWidgets __WX__ is always defined it seems on all platforms.

In KeyMap.cxx the define for OS_X_KEYS only considers GTK_MAC and not plain MAC this is also included in the diff.

1 Attachments

Discussion

  • Neil Hodgson

    Neil Hodgson - 2014-05-02
    • status: open --> open-rejected
    • assigned_to: Neil Hodgson
    • Priority: 5 --> 3
     
  • Neil Hodgson

    Neil Hodgson - 2014-05-02

    Since the platform is wxWidgets, it is not Mac-native, so PLAT_MACOSX must not be set. Instead, set up the key map in the wxWidgets-specific platform code and handle any differences for wxWidgets-on-Mac there.

     
  • Neil Hodgson

    Neil Hodgson - 2014-05-22
    • status: open-rejected --> closed-rejected
     

Log in to post a comment.

MongoDB Logo MongoDB