#1257 Virtual space kicks in unexpectedly while scrolling

[Eric Promislow]

Komodo hardwires scimoz.virtualSpaceOptions to 1 (SCVS_RECTANGULARSELECTION) only.

I can duplicate this on Scite (v202) with the property virtual.space=1

Say you have a longish buffer with the following line lengths:

...
70
70
20
...

Turn on visible End of Line (Ctrl-Shift-9 on Windows)

Put the cursor at the end of the first line of length 70.

Scroll down using ctrl-down-arrow. When the line of
length 20 is at the top of the screen, the virtual EOL
is shifted to the right.

This is unexpected, as we expect to see virtual space
only in rectangular selections.

Ref Komodo bug http://support.activestate.com/node/7527

[Neil Hodgson]

Fix committed that only allows selection into virtual space with SCI_LINESCROLLDOWN/SCI_LINESCROLLUP when SCVS_USERACCESSIBLE flag set in virtual space options.

[Marko Njezic]

You should have used Editor::UserVirtualSpace() method in order to be consistent with all other places where similar check is being performed instead of hardcoding it in these two last places.

[Neil Hodgson]

OK, updated to call UserVirtualSpace.

[Eric Promislow]

Is there a self-contained patch for this change? We have to hold up moving to v300 because we're still using Carbon in some places.

[Neil Hodgson]

Many commits contain bug numbers so entering 3451681 into the search box of a Hg GUI discovers changeset 3970.