Menu

#1109 SciTE 64-bit build bugs

Bug
closed-fixed
SciTE (664)
5
2014-08-20
2011-03-09
No

Recently I tried to build 64-bit versions of SciTE, although I don't know if this is currently supported at all.

Visual Studio 2010 builds SciTE 2.24 successfully in 64-bit mode. There are many warnings regarding type conversions, but the resulting binary seems to work - with two exceptions:

1. Menu localisation does not work, this is fixed with the attached patch scite_x64_1.diff.

2. Lua scripts freeze SciTE. I'm not sure if it's the correct fix, but the attached patch scite_x64_2.diff seems to work.

Building SciTE 2.24 with MinGW64 doesn't work. There are type conversion errors in DirectorExtension.cxx and LuaExtension.cxx. I was able to convert the errors to warnings by changing the type casts, but this was by trial and error.

Friedrich

Discussion

  • Friedrich Vedder

     
  • Friedrich Vedder

     
  • Neil Hodgson

    Neil Hodgson - 2011-03-09

    I commonly build SciTE as 64-bit on Linux and 32-bit on Windows. Others occasionally send in patches for 64-bit Windows.

    The menu localisation patch is OK as 64-bit use is now more common than NT 4.

    For iface_function_helper in LuaExtension, I expect the patch is just covering up that the params variable only contains 32-bit values and needs to be 64-bit (probably sptr_t) on Win64, particularly for the iface_string and needStringResult cases where params[1] is a pointer to string buffer.

     
  • Neil Hodgson

    Neil Hodgson - 2011-03-09
    • assigned_to: nobody --> nyamatongwe
     
  • Friedrich Vedder

     
  • Friedrich Vedder

    OK, I've changed the patch for LuaExtension.cxx (see scite_x64_3.diff). The type of the params variable is now sptr_t.

    LuaExtension.cxx with this patch applied compiles without warnings with MinGW32, MinGW64, VS 2010 (32 + 64 bit). Lua scripts work with all builds.

     
  • Neil Hodgson

    Neil Hodgson - 2011-03-13
    • status: open --> open-fixed
     
  • Neil Hodgson

    Neil Hodgson - 2011-03-13

    Committed.

     
  • Neil Hodgson

    Neil Hodgson - 2011-03-22
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.