From: R. L. <la...@us...> - 2002-01-14 11:59:13
|
bryan cole wrote: > > Attached are five patch-files to fix various little problems with SG. > The patches were made by 'cvs diff -u' (as suggected by Rob) yesterday. Applied. Few comments: 1) gzip the patches before sending to the list 2) you can have multiple patched-files in one single patch-file, like the one you create with "cvs diff -u > cvs.diff". 3) please use if (...) statement_1; else statement_2; instead of if (...) {statement_1;} else {statement_2;} 4) do not use C++ comments. 5) Last but not least: please also add (as a patch) an entry into the ChangeLog file and describe there what your patches are supposed to add or fix (please have a look at ChangeLog file). Thanks Rob. |