[Scidavis-contributors] [notifications@github.com: Re: [highperformancecoder/scidavis] Testing's changes. (#205)]

[Russell S. <hp...@hp...>]

I've just received a PR proposing changing the unit test system to
gtest from our current system of UnitTest++. I'm posting this here to
see if anyone has strong objections to the change. I'm using gtest in
another project, and I'm only mildly opposed to it, based on my
experience. I can see some definite advantages, such as integration
with gmock. Chinoune outlines some other advantages below too.

He has already done the work converting the existing tests, so we
can't argue sunk cost :).

----- Forwarded message from "مهدي شينون (Mehdi Chinoune)" <not...@gi...> -----

Date: Fri, 05 Feb 2021 20:05:04 -0800
From: "مهدي شينون (Mehdi Chinoune)" <not...@gi...>
To: highperformancecoder/scidavis <sci...@no...>
Cc: Russell Standish <hp...@hp...>, Comment
	<co...@no...>
Subject: Re: [highperformancecoder/scidavis] Testing's changes. (#205)

The reasons why I want to switch to GoogleTest are:

  • Popularity: GTest is more popular than UnitTest++ which means more tested.
    It is used by large projects like LLVM and Chromium.
  • Active: See unittest-cpp/unittest-cpp#180 and unittest-cpp/unittest-cpp#183
  • GTest has a better integration with development tools like CMake, Visual
    Studio and Qt Creator.
  • As you can see in my PR, I didn't define any static methods, I have only
    created a new class:

class ApplicationWindowTest : public ::testing::Test, public ApplicationWindow
{
};

https://github.com/highperformancecoder/scidavis/pull/205/files#
diff-5df7a5b64ccec9873e9f1a49bb8026390b8671b92aa0f8671b3dd540034cf8acR8

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.*


----- End forwarded message -----

-- 

----------------------------------------------------------------------------
Dr Russell Standish                    Phone 0425 253119 (mobile)
Principal, High Performance Coders     hp...@hp...
                      http://www.hpcoders.com.au
----------------------------------------------------------------------------