From: pgeorges <pas...@fr...> - 2006-12-30 09:37:56
|
Jeremy White a écrit : > Attached is a patch that adds a 'Blunders Only' Analysis mode to ChessDB. > > My main goal in writing this was to provide a way for me to analyze > kids games (I coach a large chess club). The kids are really > all 1000 (or lower) players, so they really can only understand > and hopefully learn from fairly gross blunders. > > So the attached patch refines the facility provided in the > 'Add variation when game move is not best move' Analysis > facility so that a variation, comment, and diagram are only > added when a (configurable) blunder was made. > > I have a number of concerns with this patch, as follows: > 1. I'm not a TK programmer; I didn't pack the dialog > very elegantly - the 'Threshold' entry field, in > particular, really needs to be tucked in and slaved > to the blunders radio button. > Not hard, I'll do it if necessary. Maybe the threshold entry could be a spinbox (easier to use). > 2. I added only english text; I wasn't sure what to do > about the other languages. Is the gracious thing to do > to add English text to the other files so that someone else > can see it to translate? > Your patch works only with language = english, otherwise there is an error. It would be a nice thing to have a tool that propagates automatically the english tokens in other files. Any Perl wizard around there ? > I appreciate comments and thoughts. > It is a really useful feature. I would also have added an option "erase old variations", in case of a second analysis with different settings. Pascal Georges |