[Sbcl-devel] pcl cleanups

[Martin A. <ma...@at...>]

Hi,

I've been hacking on PCL these days.
It mainly was about fixing bugs, and finding out how PCL worked.
Then I went along your "FIXME" notes in the code, and cleaned up
some portions of the code.
I mainly removed non ANSI hacks, hacks that are not needed any more,
ugly compiler hacks, and I enabled some portions, that were
commented out.
- non ANSI: (setf <method>) handling,
- non ANSI: *defgeneric-times*, *defmethod-times*, *defclass-times*
- make-top-level-form replaced by "eval-when" or simply removed, when
possible.
- and lots more ...

I also generalized a lot, so that one function is used for one purpose,
instead of two (instance-ref vs %instance-ref), and I moved some stuff
to internal-packages. I tried to use "internal"-functions as far as that
was possible ("once-only" ...).
There were also some functions that were not in "their" package, so I
tried to move them there.
Finally I moved some functionality concerning the compiler to a seperate
file, since one file (low.lisp) had two "IN-PACKAGE"-forms.

So, after all this, I think this should be tested, and since it works as
far as I can tell, it probably should go into the main source.
I have used PVE's ansi-test suite, specifically the "clos-test", and the
"new PCL" gives the same "CORRECT"'s (and the same errors .... :(

I could use some feedback before I work further on this,
so any feedback is appreciated. :)


Cheers,

Martin
-- 
Martin Atzmueller <ma...@at...>