Re: [Sbcl-devel] Patch: Use symbolicate instead of (intern (format ...))

[Javier O. <pi...@gm...>]

Hi,
  Thanks for your input. I was unsure if to use STRING-UPCASE, but I
ultimately I included them to match the format control string used. The
calls to STRING-UPCASE are now removed.

   I am not starting the commit message with [PATCH] git adds it
automatically when doing "git format-patch" if the -k option is not used.
However when applying the patch with "git am" removes the prefix [PATCH].
If not having [PATCH] as a prefix in the commit message of the patch is the
preferred way I suggest modifying the HACKING file to recommend using the
-k option.


On Sun, Aug 10, 2014 at 4:15 AM, Stas Boukarev <sta...@gm...> wrote:

> Javier Olaechea <pi...@gm...> writes:
>
> > Hi, this is a small patch in accordance to a fixme note in
> > x86-64/arith.lisp. I ran the test suite after the modification just in
> case.
> >
> > Hope it helps,
> >    Javier Olaechea
> >
> > --
> > "I object to doing things that computers can do." — Olin Shivers
> >
> > From b838dc32f46f6e0b632b91dfee659cab84c7c431 Mon Sep 17 00:00:00 2001
> > From: PuercoPop <pi...@gm...>
> > Date: Sat, 9 Aug 2014 19:12:55 -0500
> > Subject: [PATCH] Use symbolicate instead of (intern (format ...))
> >
> > ---
> >  src/compiler/x86-64/arith.lisp | 12 +++++-------
> >  1 file changed, 5 insertions(+), 7 deletions(-)
> >
> > diff --git a/src/compiler/x86-64/arith.lisp
> b/src/compiler/x86-64/arith.lisp
> > index b0893cc..3998678 100644
> > --- a/src/compiler/x86-64/arith.lisp
> > +++ b/src/compiler/x86-64/arith.lisp
> > @@ -1351,13 +1351,11 @@ constant shift greater than word length")))
> >               `(progn
> >                  ,@(mapcar
> >                     (lambda (suffix cost signed)
> > -                     `(define-vop (;; FIXME: These could be done more
> > -                                   ;; cleanly with SYMBOLICATE.
> > -                                   ,(intern (format nil
> "~:@(FAST-IF-~A~A~)"
> > -                                                    tran suffix))
> > -                                   ,(intern
> > -                                     (format nil
> "~:@(FAST-CONDITIONAL~A~)"
> > -                                             suffix)))
> > +                     `(define-vop (,(symbolicate "FAST-IF-"
> > +                                                 (string-upcase tran)
> > +                                                 (string-upcase suffix))
> > +                                   ,(symbolicate
> > +                                     "FAST-CONDITIONAL" (string-upcase
> suffix)))
> >                          (:translate ,tran)
> >                          (:conditional ,(if signed cond unsigned))
> >                          (:generator ,cost
> STRING-UPCASE is not needed, and starting the commit message with
> "[PATCH]" isn't great. And maybe using your real name instead of
> "PuercoPop" can be a good idea too.
>
> --
> With best regards, Stas.
>



-- 
"I object to doing things that computers can do." — Olin Shivers