From: <rj...@fd...> - 2011-05-17 17:49:18
|
Nikodemus Siivola wrote: >On 14 May 2011 01:27, <rj...@fd...> wrote: > >> These are some diffs to allow SBCL to be built with SB-THREADS for >> NetBSD/amd64. >> >> The extra *features* needed to build it are :sb-thread :gcc-tls :sb-lutex > >Thank you. > >How well does the resulting SBCL do on its tests? It fails: sb-bsd-sockets sb-concurrency sb-introspect sb-simple-streams >The preference is that end-users should not need to add things like >:gcc-tls and :sb-lutex to *features*. make-config.sh should be >adjusted to add those for NetBSD -- so that only :sb-thread needs to >be added to enable building with threads. I didn't include the diffs to make-config.sh as I thought it would be better if it got a bit more testing first. >(Though really the build should be refactored to add dependant >features like :sb-lutex conditionally on threads, and for preference >in lisp ... but that's a separate issue and beside the point here.) It could also be easier to work out how to do a port if there were closer links between the different features. >PS. For some reason the patch doesn't apply quite cleanly, but the >reject is easy to fix manually, so not a biggie. ...but for future >reference, patches against the git tree generated by "git >format-patch" are preferred. The patch was generated against CVS, I don't use git. Robert Swindells |