Re: [Sbcl-devel] Possible fix for read-char-no-hang on Win32

[Chun T. (binghe) <bin...@gm...>]

Hi, Nikodemus Siivola

I don't think directly merging these code into SBCL core is a good idea.

The patch sent from Kalyanov Dmitry was all about sockets, and will cause SBCL always static linking Winsock2 on win32. I cannot figure out why it's relevant to "read-char-no-hang", but since networking code in SBCL are all belong to SB-BSD-SOCKETS contrib package, I think this patch should be put into SB-BSD-SOCKETS, with a slightly modified form. If SBCL core have to add something about networking, that must be a hook to be touched by SB-BSD-SOCKETS when loaded.

--binghe

在 2010-9-30，17:23， Nikodemus Siivola 写道：

> On 11 July 2010 11:04, Kalyanov Dmitry <kal...@gm...> wrote:
> 
>> I've found out that it's possible to peek the input buffer size of a
>> Winsock socket by calling WSAIoctl(FIONREAD). I've tried to use it
>> for checking for available input on a socket and it seems to work.
>> 
>> Using WSAIoctl works fine when Winsock hadn't been initialized by
>> call to WSAStartup (WSAGetLastError returns WSANOTINITIALISED) and
>> when handle is not a socket (WSAGetLastError returns WSAENOTSOCK).
>> Also this doesn't modify socket in any way while WSAEventSelect sets
>> socket to non-blocking mode and changes its notification event.
>> 
>> Are there any problems with this approach?
> 
> I'm don't know nearly enough about Windows to have an educated view on
> this, but looking at
> http://msdn.microsoft.com/en-us/library/ms741621%28v=vs.85%29.aspx it
> seems reasonable enough.
> 
> If this makes things better for you and others on Windows, I think
> merging it sounds reasonable enough unless those with more Win-fu have
> objections. (I didn't review the patch properly yet, though.)
> 
> I would, however, like a test-case that passes with this but doesn't without.
> 
> Cheers,
> 
> -- Nikodemus
> 
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> Sbcl-devel mailing list
> Sbc...@li...
> https://lists.sourceforge.net/lists/listinfo/sbcl-devel