Re: [Sbcl-devel] [PATCH] sb-bsd-sockets: optimize socket-receive

[Nikodemus S. <nik...@ra...>]

On Sun, Oct 26, 2008 at 2:00 PM, Xristos Kalkanis <cc...@es...> wrote:
> SOCKET-RECEIVE as it is now allocates foreign array and copies everytime it
> gets called. There is no need for this if the user passes a simple-array
> with (unsigned-byte 8) element-type as we can use vector-sap and avoid
> allocation/copy.
>
> See attached patch.

Thank you! A couple of things:

Did you test this? I don't see how this can work, since you have added
a use of WITH-VECTOR-SAP before it's definition, which now needs to
move earlier in the file.

Also, since there is no cleanup form in the UNWIND-PROTECT anymore,
the whole UWP can go away.

Finally it would be *really* good to have an automatic test for more
socket functionality -- including socket-receive.

Cheers,

 -- Nikodemus