Re: [Sbcl-devel] [PATCH] More portable asdf-module.mk

[Eugene O. <eu...@gm...>]

Hi Richard,

On Sun, 2008-03-23 at 15:05 -0400, Richard M Kreuter wrote:

> > +	cp -R * "$(BUILD_ROOT)$(INSTALL_DIR)"
> > +	find "$(BUILD_ROOT)$(INSTALL_DIR)" -name CVS -type d -prune -exec rm -r
> >  {} \;

> I wonder if it wouldn't be saner to have each of the asdf-using
> contribs' Makefiles set a variable whose value named the files to
> install for that contrib (possibly by extracting the information from
> the asdf system), and to have the install target be
> 
> install:
> 	cp $(INSTALL_FILES) "$(BUILD_ROOT)$(INSTALL_DIR)"
> 
> Thoughts?

I personally don't like asterisking either. Moreover, I find it to be a
bit ugly to install the CVS subdirs and then to delete them from the
modules installation directories. But I don't see a better, compact and
portable way, to do it.

You're right, it'd be saner to specify every single file to be
installed. But in some modules the number of files is up to 50. Do you
think it'd be easy to maintain that stuff? If yes, I'll make a proper
patch for that.

On the other hand, all we need is to exclude the CVS subdirectories
and .cvsignore files. Hmm... while writing this email, I've noticed,
Makefiles must be excluded, too. There is no reason to copy them to the
installation directories. So, it's CVS, Makefile, and .cvsignore which
must be excluded from the files to be installed.


- Eugene