From: <wil...@ai...> - 2007-06-28 01:34:41
|
On Thu, Jun 28, 2007 at 01:51:32AM +0100, Marco Monteiro wrote: > [The changes are divided in 2 email because the patch is more that 40kb.] > > The attached patch changes the code to facilitate a possible future > implementation of modern mode Lisp. Each change is of one of: > > . Change SYMBOL to symbol or vice versa. > . Change package designator from string to symbol > . Change (intern "SOME-STRING" "SOME-PACKAGE") to > (intern (symbol-name '#:some-string) '#:some-package) > > All trivial changes. Please apply. I'm not very enthusiastic about this. Of course I see the value to those users who need to run code portably both under SBCL and under Allegro and who also choose to configure Allegro in its nonportable modern mode. However, safe cheap trivial changes though they are, they also seem to come with a global requirement that SBCL's code continue to conform to the ANSI-Standard-as-revised-by-Allegro in order to avoid code rot. Enforcing that seems to involve manual tedium or extra automated checks at compile time. We do already have checks like that for a narrower definition of allowed whitespace than ANSI uses, for noncritical reasons like improving CVS diff signal/noise ratio. So it's not completely impractical or out of the question that a noncritical reason like supporting more dialects of CL could justify this change. But it's not clear to me that modern mode is something we should be working to support. The patch doesn't seem completely out of the question, but my snap reaction to this is more like "convince me" than "OK." (Also, just as a personal favor, when someday you have been a committer on a free software project for a while and someone mails in a patch whose cover text terminates with "Please apply." I'd appreciate it if you could please CC me with your reply.:-) -- William Harold Newman <wil...@ai...> PGP key fingerprint 85 CE 1C BA 79 8D 51 8C B9 25 FB EE E0 C3 E5 7C The law, in its august majesty, does not forbid the tired and poor from inheriting citizenship. |