From: Devon S. M. <SBCL-Hackers@Jovi.Net> - 2004-12-09 13:54:18
|
Date: Thu, 9 Dec 2004 09:51:01 +0200 (EET) From: Nikodemus Siivola <tsi...@cc...> cc: sbc...@li... This makes it less likely that users will report the failures, which is all important. Also, while there may be known problems, we IMO still prefer to consider them problems, not just something to ignore... True but better say something, so change it to what you just said. > --- tests.orig/float-modes.impure.lisp Tue Dec 7 14:24:03 2004 > +++ tests/float-modes.impure.lisp Tue Dec 7 14:23:53 2004 > @@ -0,0 +1,22 @@ > +;;;; These tests check for known bugs which wrongly change > +;;;; floating point arithmetic modes such as whether to > +;;;; signal an overflow error or return an infinite value. > + > +;;;; Known broken in SBCL 0.8.16 under FreeBSD 5.2-RELEASE > +;;;; so uncomment the next line to disable this test file. > +; #+SBCL (quit :unix-status 104) ; fake success Better display the breakage: the test suite is there to show the problems, not hide them. The pertinent question is: does the current suite catch the FreeBSD 5 bugs? If not, what tests do we need to add to catch them. (From the previous messages I was under the impression that the bugs were caught.) The user must manually uncomment it to skip the test, after reading the explanation that it is a known bug. Rephrase the comment to request reports of known bugs if you really want 'em. This patch also includes brand new test files that check directly for the actual bugs, an improvement over the present behavior of randomly losing for obscure reasons as a side effect of unknown prior tests. Now, I should probably elaborate what I ment with a more sophisticated harness: eg. something that runs all the test and afterwards just reports wich ones failed. Agreed! Also nicely ask permission to mail in the results and request a return address if the user is willing to answer followup questions from developers. Peace --Devon /~\ \ / Health Care X not warfare / \ Kerry won the popular vote Dubya won the digital vote PS: Sad that a portable tester can't be written in LISP. There oughta be a standard! |