|
From: Tiago C. <cou...@es...> - 2014-03-04 16:52:42
|
Hi, On 03/04/2014 11:18 AM, Carlos Pascual wrote: > Hi, I finally ended the review of the sep10 code. Excelent news! > It took quite long because I had first to merge-in the changes from > develop since the branch was created (in order to make it ready for > merging sep10 back into develop) and then I did a more or less > exhaustive back-compatibility check in which I found several things that > needed fixing in this aspect. I did the fixes (except for those related to > documentation, which IMHO should be treated later on in relation with > tickets #98 and #5. Thanks a lot for your help > > Since there are quite a lot of changes, I think that a pull request from > my public fork is easier to handle than a long series of patches, so > here is the result of the git request-pull command: > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > git request-pull origin/sep10 cpascual > The following changes since commit > f588013ff6cb5249fb8ef3ce54824ffc907b3df1: > > Fix old code (not actually being used) (2014-01-23 14:07:49 +0100) > > are available in the git repository at: > > git://git.code.sf.net/u/cpascual/sardana sep10 > > for you to fetch changes up to 6245fae4c6524bf972ce65519ca3fb061c644f0f: > > Distribute dummy backwards compat qtgui_extra modules (2014-03-04 > > (full output in sep10-pullrequest.txt, attached) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > So, Tiago, as the sep10 lieutenant, could you please handle this pull > request? Done! > > > IMPORTANT: Once this is done, I propose to have a vote and decide > whether we agree on the current implementation. and if so, we can merge > sep10 into develop and proceed to the last details for passing sep10 to > ACCEPTED. I agree > > Cheers, > > Carlos > > > > > On Tue 25 February 2014 10:25:08 Carlos Pascual wrote: >> Hi, I finally started to review the SEP10 code. >> >> The first problem that I got is that I cannot make a clean merge of >> sep10 with the current develop branch. >> >> I'll work on this and send a patch series once I got it >> >> Carlos >> >> On Thu 23 January 2014 14:24:33 Tiago Coutinho wrote: >>> Hello all, >>> >>> I have updated taurus sep10 git to make it 100% backward compatible: >>> >>> if sardana is installed ;-) : >>> - sardana widgets are now available in taurusdesigner >>> - "old" taurus applications can still use >>> >>> taurus.qt.qtgui.extra_{pool,sardana,macroexecutor} >>> >>> (but taurus in sep10 itself is using >>> >>> sardana.taurus.qt.qtgui.extra_{pool,sardana,macroexecutor}) >>> >>> Since I have no real sardana gui in ESRF I did limited tests on >>> sardana widgets. >>> It would help if any anyone could test and complain from a real >>> application. >>> >>> Thank you all again for the quick responses >>> >>> Cheers >>> Tiago >>> >>> On 01/22/2014 02:11 PM, Tiago Coutinho wrote: >>>> On 01/22/2014 12:15 PM, Maria-Teresa, Nunez-Pardo-de-Vera wrote: >>>>> Hi, >>>>> >>>>> I agree with Carlos that is important to keep backwards >>>>> compatibility.>> >>>>> >>>>> Cheers, >>>>> >>>>> Teresa >>>> Me too! >>>> >>>>> On 01/22/14 11:58, Carlos Pascual wrote: >>>>>> Hi Tiago, >>>>>> >>>>>> On Wed 22 January 2014 10:55:38 Tiago Coutinho wrote: >>>>>>> Hello all, >>>>>>> >>>>>>> Thank you for voting so quickly (and favorably :-) to SEP10. >>>>>>> >>>>>>> SEP10 is now in CANDIDATE state. >>>>>>> >>>>>>> Work has been done to try to pass SEP10 to ACCEPTED: >>>>>>> >>>>>>> - a working implementation is available on the sep10 branch of >>>>>>> git. >>>>>>> >>>>>>> (...) >>>>>>> >>>>>>> - a new SF Taurus<www.sf.net/p/tauruslib> project has been >> created: >>>>>>> (...) >>>>>> great work! >>>>>> >>>>>> I'll need a bit of time to check everything, but in the >>>>>> meanwhile, >>>>>> I >>>>>> >>>>>> have some comments: >>>>>>> Issues: >>>>>>> - taurus GUIs that use sardana need to change their >>>>>>> imports >> from: >>>>>>> taurus.qt.qtgui.extra_{macroexecutor|sardana|pool} >>>>>>> >>>>>>> to: >>>>>>> sardana.taurus.qt.qtgui.extra_{macroexecutor|sardana| >>>>>>> po >>>>>>> ol} >>>>>> I would prefer to avoid this. >>>>>> I think that SEP10 should leave everything backwards compatible. >>>>>> Even if this means providing a provisional rough plugin >>>>>> system... >>>>>> >>>>>> But I think we can get away (for now) with just modifying >>>>>> /taurus/lib/taurus/qt/qtgui/__init__.py with something like: >>>>>> ~~~~~~~~~ >>>>>> >>>>>> try: >>>>>> from sardana.taurus.qt.qtgui import extra_macroexecutor >>>>>> from sardana.taurus.qt.qtgui import extra_sardana >>>>>> from sardana.taurus.qt.qtgui import extra_pool >>>>>> >>>>>> except ImportError: >>>>>> ... >>>>>> >>>>>> ~~~~~~~~~ >>>>>> >>>>>> For the moment, this should be enough >>>> Ok, I will do what you suggest >>>> >>>>>>> - sardana documentation in taurus must be moved to >>>>>>> sardana. >>>>>>> >>>>>>> Note however that most sardana pages in taurus >>>>>>> documentation >>>>>>> >>>>>>> are empty! >>>>>> I think this would be nice to have but I do not see it as a >>>>>> blocker for accepting SEP10 (it can be put as a bug in both the >>>>>> sardana and taurus ticket trackers) >>>> Ok, >>>> >>>>>>> - taurusgui needs to find a better way to introduce >>>>>>> sardana >>>>>>> >>>>>>> widgets (through an extension mechanism). >>>>>>> >>>>>>> In my opinion it is out of scope of this SEP to do >>>>>>> this. >>>>>>> I propose to create a new TEP dedicated to this. >>>>>> I strongly agree on creating a TEP for exploring the different >>>>>> possibilities in detail, but (as I said before) I think that >>>>>> full >>>>>> backwards compatibility should be granted by SEP10. >>>>>> >>>>>> If the above __init__.py trick is not enough for some reason, a >>>>>> plugin mechanism (no matter how provisional) should be >>>>>> implemented *within* the SEP10 to provide full backwards >>>>>> compatibility. >>>>>> >>>>>> If it was needed, I propose something like explicitly >>>>>> registering >>>>>> of >>>>>> external modules in the tauruscustomsettings.py file. >>>>>> >>>>>> For example, something like >>>>>> >>>>>> ~~~~~~~~~ >>>>>> MODULE_EXTENSIONS = {'taurus.qt.qtgui.extra_macroexecutor' : >>>>>> 'sardana.taurus.qt.qtgui.extra_macroexecutor' } > > > ------------------------------------------------------------------------------ > Subversion Kills Productivity. Get off Subversion& Make the Move to Perforce. > With Perforce, you get hassle-free workflows. Merge that actually works. > Faster operations. Version large binaries. Built-in WAN optimization and the > freedom to use Git, Perforce or both. Make the move to Perforce. > http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk > > > _______________________________________________ > Sardana-devel mailing list > Sar...@li... > https://lists.sourceforge.net/lists/listinfo/sardana-devel |