ASCII Color Palettes can not be loaded in SAGA GUI

Brought to you by: oconrad, reklov_w

#252 ASCII Color Palettes can not be loaded in SAGA GUI

Milestone: v5.1.0

Status: closed

Owner: nobody

Labels: None

Priority: 1

Updated: 2017-08-15

Created: 2017-07-23

Creator: Volker Wichmann

Private: No

SAGA color palettes in ASCII format can not be loaded in the Color Palettes dialog. Palettes in (older) binary format can be loaded, however.

Discussion

Volker Wichmann - 2017-07-23

Note: seems like this bug only affects the windows version, I'm able to load ASCII palettes on linux

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Volker Wichmann - 2017-08-05

I tried to debug this further, the "version" string in case of ASCII palettes is not parsed correctly, see screenshot - this seems to fail in api_file.cpp

313 bool CSG_File::Read_Line(CSG_String &sLine) const

where the CRLF seems not to be detected correctly. Maybe this is related to the change of using wxInputStream (in order to be able to read/write also zipped streams). Though I still have no idea why this is actually failing ...

load_ascii_palette.png
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Volker Wichmann - 2017-08-05

... for completeness, loading binary palettes works, here the "version" string is parsed correctly, see screenshot

load_binary_palette.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Olaf Conrad - 2017-08-15

status: open --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Olaf Conrad - 2017-08-15

fixed with commit [1b33ce]

Related

Commit: [1b33ce]

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous