[S3tools-commits] [ s3tools-Bugs-3025892 ] setacl --add-public does nothing if grantee user has READ

[SourceForge.net <no...@so...>]

Bugs item #3025892, was opened at 2010-07-06 15:20
Message generated for change (Tracker Item Submitted) made by smoser
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=887015&aid=3025892&group_id=178907

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: s3cmd
Group: Malfunction
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Scott Moser (smoser)
Assigned to: Nobody/Anonymous (nobody)
Summary: setacl --add-public does nothing if grantee user has READ

Initial Comment:
The 'isAnonRead' in method if the Grantee class S3/ACL.py is broken.  Instead of checking if 'self' "isAllUsers" , it checks if the 'isAllUsers' method is defined in self.

Thus, if you have any explicit grant that has 'READ', then 's3cmd setacl --acl-public s3://mybucket/myfile.txt' will decide that the file is already public and do nothing.

The fix is simple, and was also found during the adding of the feature request  for issue 28833177 [1] (see [2] to view that patch).

=== BEGIN PATCH ===
--- S3/ACL.py  2010-05-20 09:26:53 +0000
+++ S3/ACL.py  2010-07-06 15:14:27 +0000
@@ -32,7 +32,7 @@
      return self.tag == "URI" and self.name == Grantee.ALL_USERS_URI
   
   def isAnonRead(self):
-     return self.isAllUsers and self.permission == "READ"
+     return self.isAllUsers() and self.permission == "READ"
   
   def getElement(self):
      el = ET.Element("Grant")

=== END PATCH ===

--
[1]  https://sourceforge.net/tracker/index.php?func=detail&aid=2833177&group_id=178907&atid=887015
[2]  https://sourceforge.net/tracker/download.php?group_id=178907&atid=887015&file_id=338175&aid=2833177


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=887015&aid=3025892&group_id=178907