[Ryu-openstack-review] Change in openstack/neutron[master]: Set floating IP port status to "N/A"
Brought to you by:
nz_gizmoguy
|
From: Edgar M. (C. Review) <re...@op...> - 2015-03-27 23:11:59
|
Edgar Magana has posted comments on this change. Change subject: Set floating IP port status to "N/A" ...................................................................... Patch Set 9: Code-Review-1 (1 comment) https://review.openstack.org/#/c/122265/9/neutron/common/constants.py File neutron/common/constants.py: Line 32: STATUS_NOTAPPLICABLE = 'N/A' > I would call it PORT_STATUS_NOTAPPLICABLE (few lines above) I do agree with the suggestion, otherwise it could be understood as NOT AVAILABLE.. Just make it short: NOT_APPLICABLE -- To view, visit https://review.openstack.org/122265 To unsubscribe, visit https://review.openstack.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f94afa001b213d61f0e5892aae2e6e6de98fe4c Gerrit-PatchSet: 9 Gerrit-Project: openstack/neutron Gerrit-Branch: master Gerrit-Owner: Kevin Benton <kev...@bu...> Gerrit-Reviewer: A10 Networks CI <a10...@a1...> Gerrit-Reviewer: Arista CI <ari...@ar...> Gerrit-Reviewer: Armando Migliaccio <ar...@gm...> Gerrit-Reviewer: Big Switch CI <ope...@bi...> Gerrit-Reviewer: Brocade Openstack CI <Bro...@Br...> Gerrit-Reviewer: Brocade VDX CI <ope...@br...> Gerrit-Reviewer: Brocade Vyatta CI <DL-...@Br...> Gerrit-Reviewer: Cedric Brandily <zz...@gm...> Gerrit-Reviewer: Cisco APIC CI <ap...@ci...> Gerrit-Reviewer: Cisco CI <cis...@ci...> Gerrit-Reviewer: Cisco FWaaS CI <fwa...@ci...> Gerrit-Reviewer: Cisco N1kv CI <n1...@ci...> Gerrit-Reviewer: Cisco Tail-f CI <tai...@ci...> Gerrit-Reviewer: Cisco ml2 CI <ml...@ci...> Gerrit-Reviewer: Edgar Magana <em...@gm...> Gerrit-Reviewer: Freescale CI <fs...@fr...> Gerrit-Reviewer: Gal Sagie <gal...@hu...> Gerrit-Reviewer: HP Networking CI <hpn...@hp...> Gerrit-Reviewer: Huawei ML2 CI <hua...@hu...> Gerrit-Reviewer: Ihar Hrachyshka <ihr...@re...> Gerrit-Reviewer: Intel Networking CI <ope...@in...> Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Kevin Benton <kev...@bu...> Gerrit-Reviewer: Mellanox CI <mln...@de...> Gerrit-Reviewer: Metaplugin CI <met...@gm...> Gerrit-Reviewer: Microsoft Hyper-V CI <hyp...@mi...> Gerrit-Reviewer: NEC CI <nec...@ia...> Gerrit-Reviewer: Nuage CI <nua...@nu...> Gerrit-Reviewer: One Convergence CI <oc-...@on...> Gerrit-Reviewer: OpenContrail CI Gerrit-Reviewer: OpenDaylight CI <odl...@op...> Gerrit-Reviewer: PLUMgrid CI <plu...@pl...> Gerrit-Reviewer: Paul Michali <pc...@mi...> Gerrit-Reviewer: Ryu CI <ryu...@li...> Gerrit-Reviewer: Salvatore Orlando <sal...@gm...> Gerrit-Reviewer: Sayaji Patil <say...@gm...> Gerrit-Reviewer: Trinath Somanchi <tri...@fr...> Gerrit-Reviewer: VMware NSX CI Gerrit-HasComments: Yes |