[Rubyeclipse-commit] SF.net SVN: rubyeclipse: [3140] trunk/org.rubypeople.rdt.core/src/org/ rubypeople/rdt/internal/codeassist/CompletionEngine.java

[<caw...@us...>]

Revision: 3140
          http://rubyeclipse.svn.sourceforge.net/rubyeclipse/?rev=3140&view=rev
Author:   cawilliams
Date:     2007-09-12 07:32:02 -0700 (Wed, 12 Sep 2007)

Log Message:
-----------
when doing code completions for method calls, only include all methods starting with user's prefix if our type inferrencing is unsure of type - no guesses (Object) or multiple guesses.

Modified Paths:
--------------
    trunk/org.rubypeople.rdt.core/src/org/rubypeople/rdt/internal/codeassist/CompletionEngine.java

Modified: trunk/org.rubypeople.rdt.core/src/org/rubypeople/rdt/internal/codeassist/CompletionEngine.java
===================================================================
--- trunk/org.rubypeople.rdt.core/src/org/rubypeople/rdt/internal/codeassist/CompletionEngine.java	2007-09-11 20:04:25 UTC (rev 3139)
+++ trunk/org.rubypeople.rdt.core/src/org/rubypeople/rdt/internal/codeassist/CompletionEngine.java	2007-09-12 14:32:02 UTC (rev 3140)
@@ -157,7 +157,10 @@
 					}
 					list.addAll(mapAll.values());		
 				}
-				list.addAll(suggestAllMethodsMatchingPrefix(script)); // FIXME Only do this if we have no suggestions? Have a minimum length threshold?
+				// Only search for all methods matching prefix if we're unsure of type (multiple guesses, or none)
+				if (guesses.size() > 1 || (guesses.size() == 1 && guesses.get(0).getType().equals(OBJECT))) {
+					list.addAll(suggestAllMethodsMatchingPrefix(script)); 
+				}
 				Collections.sort(list, new CompletionProposalComparator());
 				for (CompletionProposal proposal : list) {
 					fRequestor.accept(proposal);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.