[Rubyeclipse-commit] SF.net SVN: rubyeclipse: [3018] trunk/com.aptana.rdt/src/com/aptana/rdt/ internal/parser/warnings

[<caw...@us...>]

Revision: 3018
          http://rubyeclipse.svn.sourceforge.net/rubyeclipse/?rev=3018&view=rev
Author:   cawilliams
Date:     2007-08-21 09:48:02 -0700 (Tue, 21 Aug 2007)

Log Message:
-----------


Modified Paths:
--------------
    trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/UnusedParameterVisitor.java
    trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/UnusedPrivateMethodVisitor.java

Modified: trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/UnusedParameterVisitor.java
===================================================================
--- trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/UnusedParameterVisitor.java	2007-08-21 16:40:09 UTC (rev 3017)
+++ trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/UnusedParameterVisitor.java	2007-08-21 16:48:02 UTC (rev 3018)
@@ -12,6 +12,9 @@
 import org.jruby.ast.LocalVarNode;
 import org.jruby.ast.Node;
 import org.jruby.evaluator.Instruction;
+import org.jruby.lexer.yacc.IDESourcePosition;
+import org.jruby.lexer.yacc.ISourcePosition;
+import org.rubypeople.rdt.core.compiler.IProblem;
 import org.rubypeople.rdt.core.parser.warnings.RubyLintVisitor;
 import org.rubypeople.rdt.internal.core.util.ASTUtil;
 
@@ -41,7 +44,10 @@
 	
 	public void exitDefnNode(DefnNode iVisited) {
 		for (Node unused : declared.values()) {
-			createProblem(unused.getPosition(), "Unused Method parameter " + ASTUtil.getNameReflectively(unused));
+			String name = ASTUtil.getNameReflectively(unused);
+			ISourcePosition original = unused.getPosition();
+			ISourcePosition pos = new IDESourcePosition(original.getFile(), original.getStartLine(), original.getEndLine(), original.getStartOffset(), original.getStartOffset() + name.length());
+			createProblem(pos, "Unused Method parameter " + name);
 		}
 		declared.clear();
 	}
@@ -70,4 +76,8 @@
 		return super.visitLocalVarNode(iVisited);
 	}
 
+	@Override
+	protected int getProblemID() {
+		return IProblem.ArgumentIsNeverUsed;
+	}
 }

Modified: trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/UnusedPrivateMethodVisitor.java
===================================================================
--- trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/UnusedPrivateMethodVisitor.java	2007-08-21 16:40:09 UTC (rev 3017)
+++ trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/UnusedPrivateMethodVisitor.java	2007-08-21 16:48:02 UTC (rev 3018)
@@ -14,6 +14,7 @@
 import org.jruby.ast.VCallNode;
 import org.jruby.evaluator.Instruction;
 import org.jruby.runtime.Visibility;
+import org.rubypeople.rdt.core.compiler.IProblem;
 import org.rubypeople.rdt.core.parser.warnings.RubyLintVisitor;
 import org.rubypeople.rdt.internal.core.util.ASTUtil;
 
@@ -84,5 +85,10 @@
 	protected String getOptionKey() {
 		return AptanaRDTPlugin.COMPILER_PB_UNUSED_PRIVATE_MEMBER;
 	}	
+	
+	@Override
+	protected int getProblemID() {
+		return IProblem.UnusedPrivateMethod;
+	}
 
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.