[Rubyeclipse-commit] SF.net SVN: rubyeclipse: [2988] trunk/com.aptana.rdt/src/com/aptana/rdt/ internal/parser/warnings

[<caw...@us...>]

Revision: 2988
          http://rubyeclipse.svn.sourceforge.net/rubyeclipse/?rev=2988&view=rev
Author:   cawilliams
Date:     2007-08-15 12:33:05 -0700 (Wed, 15 Aug 2007)

Log Message:
-----------
add some hacky quick fixes for mis-spelled constructor method and constant that isn't all upper case

Modified Paths:
--------------
    trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/ConstantNamingConvention.java
    trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/MisspelledConstructorVisitor.java

Modified: trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/ConstantNamingConvention.java
===================================================================
--- trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/ConstantNamingConvention.java	2007-08-15 19:32:59 UTC (rev 2987)
+++ trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/ConstantNamingConvention.java	2007-08-15 19:33:05 UTC (rev 2988)
@@ -2,12 +2,16 @@
 
 import org.jruby.ast.ConstDeclNode;
 import org.jruby.evaluator.Instruction;
+import org.jruby.lexer.yacc.IDESourcePosition;
+import org.jruby.lexer.yacc.ISourcePosition;
 import org.rubypeople.rdt.core.parser.warnings.RubyLintVisitor;
 
 import com.aptana.rdt.AptanaRDTPlugin;
 
 public class ConstantNamingConvention extends RubyLintVisitor {
 
+	public static final int PROBLEM_ID = 1234568;
+
 	public ConstantNamingConvention(String contents) {
 		super(contents);
 	}
@@ -21,9 +25,16 @@
 	public Instruction visitConstDeclNode(ConstDeclNode iVisited) {
 		String name = iVisited.getName();
 		if (!name.toUpperCase().equals(name)) {
-			createProblem(iVisited.getPosition(), "Constant name doesn't match ALL_CAPS_WITH_UNDERSCORES convention: " + name);
+			ISourcePosition pos = iVisited.getPosition();
+			IDESourcePosition duh = new IDESourcePosition("", pos.getStartLine(), pos.getEndLine(), pos.getStartOffset(), pos.getStartOffset() + name.length() - 1);
+			createProblem(duh, "Constant name doesn't match ALL_CAPS_WITH_UNDERSCORES convention: " + name);
 		}
 		return super.visitConstDeclNode(iVisited);
 	}
+	
+	@Override
+	protected int getProblemID() {
+		return PROBLEM_ID;
+	}
 
 }

Modified: trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/MisspelledConstructorVisitor.java
===================================================================
--- trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/MisspelledConstructorVisitor.java	2007-08-15 19:32:59 UTC (rev 2987)
+++ trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/MisspelledConstructorVisitor.java	2007-08-15 19:33:05 UTC (rev 2988)
@@ -8,6 +8,8 @@
 
 public class MisspelledConstructorVisitor extends RubyLintVisitor {
 
+	public static final int PROBLEM_ID = 1234567;
+
 	public MisspelledConstructorVisitor(String contents) {
 		super(AptanaRDTPlugin.getDefault().getOptions(), contents);
 	}
@@ -27,6 +29,6 @@
 
 	@Override
 	protected int getProblemID() {
-		return 1234567;
+		return PROBLEM_ID;
 	}
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.