[Rubyeclipse-commit] SF.net SVN: rubyeclipse: [2924] trunk/com.aptana.rdt/src/com/aptana/rdt/ internal/parser/warnings/RubyRedLint.java

[<caw...@us...>]

Revision: 2924
          http://rubyeclipse.svn.sourceforge.net/rubyeclipse/?rev=2924&view=rev
Author:   cawilliams
Date:     2007-08-02 11:37:46 -0700 (Thu, 02 Aug 2007)

Log Message:
-----------
only execute RubyLintVisitor if it's results won't be ignored. (this should avoid uneccesary CPU and memory usage for visitors whose results were just ignored).

Modified Paths:
--------------
    trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/RubyRedLint.java

Modified: trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/RubyRedLint.java
===================================================================
--- trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/RubyRedLint.java	2007-08-02 18:37:42 UTC (rev 2923)
+++ trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/RubyRedLint.java	2007-08-02 18:37:46 UTC (rev 2924)
@@ -84,6 +84,11 @@
 		visitors.add(new AndOrUsedOnRighthandAssignment(contents));
 		visitors.add(new ConstantNamingConvention(contents));
 		visitors.add(new MethodMissingWithoutRespondTo(contents));
-		return visitors;
+		List<RubyLintVisitor> filtered = new ArrayList<RubyLintVisitor>();
+		for (RubyLintVisitor visitor : visitors) {
+			if (visitor.isIgnored()) continue;
+			filtered.add(visitor);
+		}
+		return filtered;
 	}
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.