[Rubyeclipse-commit] SF.net SVN: rubyeclipse: [2921] trunk/com.aptana.rdt/src/com/aptana/rdt/ internal/parser/warnings/MethodMissingWithoutRespondTo.java

[<caw...@us...>]

Revision: 2921
          http://rubyeclipse.svn.sourceforge.net/rubyeclipse/?rev=2921&view=rev
Author:   cawilliams
Date:     2007-08-02 10:50:41 -0700 (Thu, 02 Aug 2007)

Log Message:
-----------


Modified Paths:
--------------
    trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/MethodMissingWithoutRespondTo.java

Modified: trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/MethodMissingWithoutRespondTo.java
===================================================================
--- trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/MethodMissingWithoutRespondTo.java	2007-08-02 17:50:08 UTC (rev 2920)
+++ trunk/com.aptana.rdt/src/com/aptana/rdt/internal/parser/warnings/MethodMissingWithoutRespondTo.java	2007-08-02 17:50:41 UTC (rev 2921)
@@ -12,6 +12,9 @@
 
 public class MethodMissingWithoutRespondTo extends RubyLintVisitor {
 
+	private static final String RESPOND_TO = "respond_to";
+	private static final String METHOD_MISSING = "method_missing";
+	
 	private Map<String, DefnNode> methods = new HashMap<String, DefnNode>();
 	
 	public MethodMissingWithoutRespondTo(String contents) {
@@ -31,8 +34,8 @@
 	
 	@Override
 	public void exitClassNode(ClassNode iVisited) {
-		if (methods.containsKey("method_missing") && !methods.containsKey("respond_to")) {
-			createProblem(methods.get("method_missing").getNameNode().getPosition(), "Class defines method_missing, but does not define custom respond_to");
+		if (methods.containsKey(METHOD_MISSING) && !methods.containsKey(RESPOND_TO)) {
+			createProblem(methods.get(METHOD_MISSING).getNameNode().getPosition(), "Class defines method_missing, but does not define custom respond_to");
 		}
 		methods.clear();
 		super.exitClassNode(iVisited);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.