[Rubyeclipse-commit] SF.net SVN: rubyeclipse: [2364] trunk/org.rubypeople.rdt.debug.ui/src/org/ rubypeople/rdt/internal/debug/ui/rubyvms

[<caw...@us...>]

Revision: 2364
          http://svn.sourceforge.net/rubyeclipse/?rev=2364&view=rev
Author:   cawilliams
Date:     2007-04-25 15:34:38 -0700 (Wed, 25 Apr 2007)

Log Message:
-----------
re-arrange fields, so user picks install location before entering name. Also add explanatory text telling user to enter/browse to the ruby install, not the executable!

Modified Paths:
--------------
    trunk/org.rubypeople.rdt.debug.ui/src/org/rubypeople/rdt/internal/debug/ui/rubyvms/AddVMDialog.java
    trunk/org.rubypeople.rdt.debug.ui/src/org/rubypeople/rdt/internal/debug/ui/rubyvms/RubyVMMessages.java
    trunk/org.rubypeople.rdt.debug.ui/src/org/rubypeople/rdt/internal/debug/ui/rubyvms/RubyVMMessages.properties

Modified: trunk/org.rubypeople.rdt.debug.ui/src/org/rubypeople/rdt/internal/debug/ui/rubyvms/AddVMDialog.java
===================================================================
--- trunk/org.rubypeople.rdt.debug.ui/src/org/rubypeople/rdt/internal/debug/ui/rubyvms/AddVMDialog.java	2007-04-25 22:20:48 UTC (rev 2363)
+++ trunk/org.rubypeople.rdt.debug.ui/src/org/rubypeople/rdt/internal/debug/ui/rubyvms/AddVMDialog.java	2007-04-25 22:34:38 UTC (rev 2364)
@@ -228,16 +228,22 @@
 		fVMTypeCombo.doFillIntoGrid(parent, 3);
 		((GridData)fVMTypeCombo.getComboControl(null).getLayoutData()).widthHint= convertWidthInCharsToPixels(50);
 
-		fVMName.doFillIntoGrid(parent, 3);
-	
+		Label l = new Label(parent, SWT.NONE);
+		l.setText(RubyVMMessages.enterRubyInstallLocation); 
+		GridData gd = new GridData(GridData.FILL_HORIZONTAL);
+		gd.horizontalSpan = 3;
+		l.setLayoutData(gd);	
+		
 		fRubyVMRoot.doFillIntoGrid(parent, 3);
 		
+		fVMName.doFillIntoGrid(parent, 3);		
+		
 		fVMArgs.doFillIntoGrid(parent, 3);
 		((GridData)fVMArgs.getTextControl(null).getLayoutData()).widthHint= convertWidthInCharsToPixels(50);
 		
-		Label l = new Label(parent, SWT.NONE);
+		l = new Label(parent, SWT.NONE);
 		l.setText(RubyVMMessages.AddVMDialog_JRE_system_libraries__1); 
-		GridData gd = new GridData(GridData.FILL_HORIZONTAL);
+		gd = new GridData(GridData.FILL_HORIZONTAL);
 		gd.horizontalSpan = 3;
 		l.setLayoutData(gd);	
 		

Modified: trunk/org.rubypeople.rdt.debug.ui/src/org/rubypeople/rdt/internal/debug/ui/rubyvms/RubyVMMessages.java
===================================================================
--- trunk/org.rubypeople.rdt.debug.ui/src/org/rubypeople/rdt/internal/debug/ui/rubyvms/RubyVMMessages.java	2007-04-25 22:20:48 UTC (rev 2363)
+++ trunk/org.rubypeople.rdt.debug.ui/src/org/rubypeople/rdt/internal/debug/ui/rubyvms/RubyVMMessages.java	2007-04-25 22:34:38 UTC (rev 2364)
@@ -31,6 +31,7 @@
 	public static String InstalledJREsBlock_15;
 	public static String JREsPreferencePage_2;
 	public static String JREsPreferencePage_1;
+	public static String enterRubyInstallLocation;
 
 	static {
 		// load message values from bundle file

Modified: trunk/org.rubypeople.rdt.debug.ui/src/org/rubypeople/rdt/internal/debug/ui/rubyvms/RubyVMMessages.properties
===================================================================
--- trunk/org.rubypeople.rdt.debug.ui/src/org/rubypeople/rdt/internal/debug/ui/rubyvms/RubyVMMessages.properties	2007-04-25 22:20:48 UTC (rev 2363)
+++ trunk/org.rubypeople.rdt.debug.ui/src/org/rubypeople/rdt/internal/debug/ui/rubyvms/RubyVMMessages.properties	2007-04-25 22:34:38 UTC (rev 2364)
@@ -1,3 +1,4 @@
+enterRubyInstallLocation=Please enter or browse to your the ruby install location.\nThis will typically be /usr, /usr/local, /opt or C:\\ruby.\nThis is the location of the ruby install, not the executable.\nWe will auto-detect the executable from this path.
 addVMDialog_pickJRERootDialog_message=Select the root directory of the Ruby installation:\n(For *nix systems, this may be /usr or /usr/local. If the ruby executable is in /usr/local/bin/ruby, use /usr/local).
 addVMDialog_enterLocation=Enter the location of the Ruby VM.
 addVMDialog_locationNotExists=The location does not exist.
@@ -9,7 +10,7 @@
 addVMDialog_duplicateName=The name is already used.
 addVMDialog_enterName=Enter a name for the RubyVM.
 addVMDialog_jreHome=&RubyVM home directory:
-addVMDialog_jreName=RubyVM &name:
+addVMDialog_jreName=RubyVM display &name:
 addVMDialog_jreType=RubyVM &type:
 AddVMDialog_23=Default &VM Arguments:
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.