[Rubyeclipse-commit] SF.net SVN: rubyeclipse: [2296] trunk/org.rubypeople.rdt.refactoring/src/ org/rubypeople/rdt/refactoring/ui/pages/InlineLocalPage.java

[<mir...@us...>]

Revision: 2296
          http://svn.sourceforge.net/rubyeclipse/?rev=2296&view=rev
Author:   mirkostocker
Date:     2007-04-11 05:05:17 -0700 (Wed, 11 Apr 2007)

Log Message:
-----------
inline local GUI had a problem with the back button and the error message, this fixes it

Modified Paths:
--------------
    trunk/org.rubypeople.rdt.refactoring/src/org/rubypeople/rdt/refactoring/ui/pages/InlineLocalPage.java

Modified: trunk/org.rubypeople.rdt.refactoring/src/org/rubypeople/rdt/refactoring/ui/pages/InlineLocalPage.java
===================================================================
--- trunk/org.rubypeople.rdt.refactoring/src/org/rubypeople/rdt/refactoring/ui/pages/InlineLocalPage.java	2007-04-06 15:54:53 UTC (rev 2295)
+++ trunk/org.rubypeople.rdt.refactoring/src/org/rubypeople/rdt/refactoring/ui/pages/InlineLocalPage.java	2007-04-11 12:05:17 UTC (rev 2296)
@@ -55,13 +55,22 @@
 
 	private String selectedItemName;
 
+	private LabeledTextField newMethodName;
+
+	private Button checkQuery;
+
 	public InlineLocalPage(InlineLocalConfig config, int occurencesCount, String selectedItemName) {
 		super(InlineLocalRefactoring.NAME + "..."); //$NON-NLS-1$
 
 		this.config = config;
 		this.occurencesCount = occurencesCount;
 		this.selectedItemName = selectedItemName;
+	}
 
+	@Override
+	public void pageIsEnabled() {
+		super.pageIsEnabled();
+		newMethodName.setEnabled(checkQuery.getSelection());
 	}
 
 	public void createControl(Composite parent) {
@@ -84,12 +93,11 @@
 	private void initExtractArea(Composite control) {
 		Group queryGroup = initGroup(control);
 
-		final Button checkQuery = new Button(queryGroup, SWT.CHECK);
+		checkQuery = new Button(queryGroup, SWT.CHECK);
 		checkQuery.setText(Messages.InlineTempPage_ReplaceTempWithQuery);
 		checkQuery.setEnabled(true);
 
-		final LabeledTextField newMethodName = new LabeledTextField(queryGroup, Messages.InlineTempPage_NewMethodName);
-		newMethodName.setEnabled(checkQuery.getSelection());
+		newMethodName = new LabeledTextField(queryGroup, Messages.InlineTempPage_NewMethodName);
 		GridData textData = new GridData(GridData.FILL_HORIZONTAL);
 		newMethodName.setLayoutData(textData);
 
@@ -98,6 +106,7 @@
 	}
 
 	private void createModifyListener(final Text newMethodName) {
+		
 		newMethodName.addModifyListener(new ModifyListener() {
 
 			public void modifyText(ModifyEvent e) {
@@ -129,8 +138,13 @@
 			}
 
 			public void widgetSelected(SelectionEvent e) {
-				newMethodName.setEnabled(checkQuery.getSelection());
-				config.setReplaceTempWithQuery(checkQuery.getSelection());
+				boolean doReplaceTempWithQuery = checkQuery.getSelection();
+				newMethodName.setEnabled(doReplaceTempWithQuery);
+				config.setReplaceTempWithQuery(doReplaceTempWithQuery);
+				if (!doReplaceTempWithQuery) {
+					setMessage(null);
+				}
+				setPageComplete(!doReplaceTempWithQuery);
 			}
 		});
 	}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.