[Rubyeclipse-commit] SF.net SVN: rubyeclipse: [2051] trunk/org.rubypeople.rdt.ui/src/org/ rubypeople/rdt/ui/wizards/RubyTypeSelectionDialog.java

[<caw...@us...>]

Revision: 2051
          http://svn.sourceforge.net/rubyeclipse/?rev=2051&view=rev
Author:   cawilliams
Date:     2007-02-27 06:48:01 -0800 (Tue, 27 Feb 2007)

Log Message:
-----------
add task markers to note that this dialog won't show all the classes in the system, and that to do so we'd need to do a full depth search via Rubyproject.getSourceFolders. Unfortunately thats way too slow, so we'd need to hook it up to the search engine like JDT does to get it to perform OK.

Modified Paths:
--------------
    trunk/org.rubypeople.rdt.ui/src/org/rubypeople/rdt/ui/wizards/RubyTypeSelectionDialog.java

Modified: trunk/org.rubypeople.rdt.ui/src/org/rubypeople/rdt/ui/wizards/RubyTypeSelectionDialog.java
===================================================================
--- trunk/org.rubypeople.rdt.ui/src/org/rubypeople/rdt/ui/wizards/RubyTypeSelectionDialog.java	2007-02-27 14:45:43 UTC (rev 2050)
+++ trunk/org.rubypeople.rdt.ui/src/org/rubypeople/rdt/ui/wizards/RubyTypeSelectionDialog.java	2007-02-27 14:48:01 UTC (rev 2051)
@@ -31,6 +31,8 @@
      * @return
      */
     protected Object[] getElements() {
+    	// FIXME This doesn't pick up all the classes in loadpaths (Ruby library)! We need to search through rubProject.getSourceFolders to do that.
+    	// FIXME If we move to grabbing all types via source fodlers it gets way too slow. We need to make this set up liek JDT so it runs a search job based on input and caches results.
         return getAllTypes();
     }
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.