[Rubyeclipse-commit] SF.net SVN: rubyeclipse: [2002] trunk/org.rubypeople.rdt.core/src/org/ rubypeople/rdt/internal/codeassist/SelectionEngine.java

[<caw...@us...>]

Revision: 2002
          http://svn.sourceforge.net/rubyeclipse/?rev=2002&view=rev
Author:   cawilliams
Date:     2007-02-22 11:36:48 -0800 (Thu, 22 Feb 2007)

Log Message:
-----------


Modified Paths:
--------------
    trunk/org.rubypeople.rdt.core/src/org/rubypeople/rdt/internal/codeassist/SelectionEngine.java

Modified: trunk/org.rubypeople.rdt.core/src/org/rubypeople/rdt/internal/codeassist/SelectionEngine.java
===================================================================
--- trunk/org.rubypeople.rdt.core/src/org/rubypeople/rdt/internal/codeassist/SelectionEngine.java	2007-02-22 19:35:43 UTC (rev 2001)
+++ trunk/org.rubypeople.rdt.core/src/org/rubypeople/rdt/internal/codeassist/SelectionEngine.java	2007-02-22 19:36:48 UTC (rev 2002)
@@ -46,7 +46,6 @@
 				start);
 
 		if (selected instanceof Colon2Node) {
-//			 FIXME What if we have a constant with multiple parts (i.e. TMail::Mail)?
 			String simpleName = ((Colon2Node)selected).getName();
 			String fullyQualifiedName = ASTUtil.getFullyQualifiedName((Colon2Node) selected);
 			IRubyElement element = findChild(simpleName, IRubyElement.TYPE, script);
@@ -65,6 +64,7 @@
 			ConstNode constNode = (ConstNode) selected;
 			String name = constNode.getName();
 			// Try to find a matching constant in this script
+			// TODO Use convention of all caps versus camelcase to decided which to search for first?
 			IRubyElement element = findChild(name, IRubyElement.CONSTANT, script);
 			if (element != null) {
 			  return new IRubyElement[] { element };	


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.