[Rubyeclipse-commit] SF.net SVN: rubyeclipse: [1595] trunk/org.rubypeople.rdt.core/src/org/ rubypeople/rdt/internal/core/parser/RubyLintVisitor.java

[<caw...@us...>]

Revision: 1595
          http://svn.sourceforge.net/rubyeclipse/?rev=1595&view=rev
Author:   cawilliams
Date:     2006-08-30 17:02:55 -0700 (Wed, 30 Aug 2006)

Log Message:
-----------
if no preference setting for a particular Lint finding, treat it as a Warning, not an Error

Modified Paths:
--------------
    trunk/org.rubypeople.rdt.core/src/org/rubypeople/rdt/internal/core/parser/RubyLintVisitor.java

Modified: trunk/org.rubypeople.rdt.core/src/org/rubypeople/rdt/internal/core/parser/RubyLintVisitor.java
===================================================================
--- trunk/org.rubypeople.rdt.core/src/org/rubypeople/rdt/internal/core/parser/RubyLintVisitor.java	2006-08-31 00:01:55 UTC (rev 1594)
+++ trunk/org.rubypeople.rdt.core/src/org/rubypeople/rdt/internal/core/parser/RubyLintVisitor.java	2006-08-31 00:02:55 UTC (rev 1595)
@@ -111,12 +111,6 @@
 		return super.visitDefsNode(iVisited);
 	}
 
-	protected Instruction handleNode(Node visited) {
-		// System.out.println(visited.toString() + ", position -> "
-		// + visited.getPosition());
-		return super.handleNode(visited);
-	}
-
 	public Instruction visitConstDeclNode(ConstDeclNode iVisited) {
 		String name = iVisited.getName();
 
@@ -128,14 +122,10 @@
 	}
 
 	private IProblem createProblem(String compilerOption, ISourcePosition position, String message) {
-		String value = RubyCore.getOption(compilerOption);
-		if (value == null)
+		String value = RubyCore.getOption(compilerOption);			
+		if (value != null && value.equals(RubyCore.ERROR))
 			return new Error(position, message);
-		if (value.equals(RubyCore.WARNING))
-			return new Warning(position, message);
-		if (value.equals(RubyCore.ERROR))
-			return new Error(position, message);
-		return null;
+		return new Warning(position, message);
 	}
 
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.