[RDT-Dev] Re: Ruby RDT Patches

[Adam W. <ad...@th...>]

> The first item leads to the question, if we are using different 
> milestone releases of Eclipse. I still use M6 but could update to M7, 
> if you are using M7. Maybe we should stick to one milestone release 
> after we have aligned our environments until it is agreed with 
> everybody to switch the version.
>

I would agree that we should stick to a M release until we all decide 
otherwise. That being said, I think we should move to new releases as 
fast as possible.

> Although I couldn't run the workbench with your additions, my feeling 
> is that you are on a good way. I'd guess that you'll soon be a project 
> member and be able to check in our code eventually. But before that I 
> would like to discuss the following issues:
>
> 1) There is a copyright of Xerox in the source. We discussed the 
> license issue before, but did not come to a conclusion. On the 
> sourceforge page the license is specified as GPL. So we should add the 
> GNU preamble to all source files. What do you think?

I would actually consider looking at the Ruby license, just because a 
friend I respect chose that for Test::Unit. Then, I think we should add 
a reference to it to all source files. If any company could ever claim 
copyright ownership, it would be RoleModel Software. Plenty of the work 
I did was during my time there.

> 2) There were quite a few differences in the patch just because of 
> formatting changes. We have discussed this earlier and agreed to the 
> following settings:
> Line split is set to 500. "Insert a new line inside an empty block" is 
> checked. "Indentation is represented by a tab" is checked.

Right. These work great. Remember to format before you save, and 
execute that handy organize imports action (no stars, please). I really 
appreciate being able to look at imports to see what a prototype thinks 
it's responsibilities are.

>
> 3) The unit tests reside in org.rubypeople.rdt.core. We have splitted 
> them in *.test projects so far (for reason of easier runtime package 
> creation and no dependency to junit.). Did you have any reasons to put 
> them directly into the org.rubypeople.rdt.core.test project?
>

On other projects, I have been trained to and always appreciated 
putting test cases in the packages of the types that are being tested.  
For this, it definitely seemed wise to have them external for the 
reasons Markus mentioned. I would still desire that, unless someone 
shares something better.

>
> Adam, I tried to build the rdt with site.xml > PDE Tools > Build Site, 
> but it fails with "Build fails, check the logs folder in the update 
> site project for details". Sadly, there is no such file.
> Whats going to happen with your update site at rolemodelsoft? Is it 
> still accessible for you?
>

I believe that it would be, but I have to check with Ken Auer before I 
can claim that with certainty. Actually, I don't think there is any 
reason we couldn't put the update site on the server you have the wiki 
on, if that is a possibility. Or, we may even be able to put it on our 
sourceforge site. As for the problem you mention above, I don't have a 
clue right now. I really hope to catch up with you guys in the next 
couple weeks. Sorry I can't help right now!! :(

Man, that is a massive stack trace! 58 more?!?!

  adam