|
From: Masao M. <mu...@hi...> - 2004-01-31 17:25:10
|
Hi Archit, > > The file can be found there: > > http://puggy.symonds.net/~bighead/ruby-libglade-sugar-patch-pre1.diff I checked it, and have some questions/comments. * GladeXml#widget_names Good feature. But REXML is NOT standard library in ruby-1.6.x. And I think it's not so difficult to get ids from glade file without any XML parser. Could you re-write it without REXML? * GladeXMLSugar Interesting. But I think it makes some restriction of the ids. e.g.) need to avoid the ids like as "class", "name", "new", "constants", .... So I don't apply this feature now. # And also I don't like the name, though it's a small issue. * GladeXML#filename Thanks. Applied. -- .:% Masao Mutoh<mu...@hi...> |