Menu

#71 mkmf-gnome2.rb doesn't like an empty *_MICRO_VERSION.

closed
None
5
2006-11-05
2006-11-04
mezz
No

When I tried to build ruby-gtkmozembed with Firefox
2.x and got a build failure, because of it only has
2.0 and not 2.0.0. I had to add a bandaid to get the
build success (will attaching a patch). For example,
without patch I get this in gtkmozembed/src/
rbgtkmozembedversion.h looks like:

============================
#define GTKMOZEMBED_MAJOR_VERSION (2)
#define GTKMOZEMBED_MINOR_VERSION (0)
#define GTKMOZEMBED_MICRO_VERSION ()
============================

============================
rbgtkmozembed.c: In function `Init_gtkmozembed':
rbgtkmozembed.c:727: error: syntax error before ')'
token
*** Error code 1
============================

After I created a patch and now it will looking like
this:

============================
#define GTKMOZEMBED_MAJOR_VERSION (2)
#define GTKMOZEMBED_MINOR_VERSION (0)
#define GTKMOZEMBED_MICRO_VERSION (0)
============================

I am sure that you will coming up with a better patch
than mine that is more flexible. :-)

Discussion

  • mezz

    mezz - 2006-11-04

    a patch to not allow *_MICRO_VERSION to be empty

     
  • Masao Mutoh

    Masao Mutoh - 2006-11-05
    • assigned_to: nobody --> mutoh
    • status: open --> closed
     
  • Masao Mutoh

    Masao Mutoh - 2006-11-05

    Logged In: YES
    user_id=495147

    Fixed.
    Use Ruby/GLib2 in CVS if you try it now, please.

    Thanks for reporting.

     
  • mezz

    mezz - 2006-11-05

    Logged In: YES
    user_id=697129

    Your fix in CVS works fine to build with Firefox 2.x that only has "2.0". Thanks!

     

Log in to post a comment.

MongoDB Logo MongoDB