ruby-dbi-devel

[Ruby-DBI-devel] pg driver quoting

[Brad H. <bh...@vp...>]

Hi,

Using ruby-dbi 0.0.16, ruby-postgres 0.6.5, and postgres 7.2.1, quoting 
of '\' characters seems broken.

The mysql driver quotes \ as:

'\\'

The pg driver quotes it as:

'\'

which causes an sql syntax error because the closing quote is eaten up.

I've been double checking my results because I'm surprised nobody else 
has seen this problem.  Can anyone duplicate this?

Thanks,
-Brad

Re: [Ruby-DBI-devel] pg driver quoting

[KAWAJI S. <ka...@ho...>]

Brad Hilton <bh...@vp...> wrote:

> The mysql driver quotes \ as:
> 
> '\\'
> 
> The pg driver quotes it as:
> 
> '\'


Because, dbd_mysql define an own quote method (MySQL's API is used),
but dbd_postgres does not (Postgres's API dosen't have 'quote').

Try this patch.(untested)


--- Pg.rb.bak   Sun Aug 11 01:54:34 2002
+++ Pg.rb       Sun Aug 11 01:54:34 2002
@@ -304,6 +304,15 @@
          @connection.exec(sql)
        end

+       def quote(value)
+         case value
+         when String
+           "'#{ value.gsub(/\\/){ '\\\\' } }'"
+         else
+           super
+         end
+       end
+
        private # ----------------------------------------------------

        def initialize_autocommit


SEE ALSO: Perl's DBD::Pg
http://search.cpan.org/author/JBAKER/DBD-Pg-1.13/Pg.pm#quote

--
Shinya Kawaji

Re: [Ruby-DBI-devel] pg driver quoting

[Brad H. <bh...@vp...>]

On Sat, 2002-08-10 at 09:59, KAWAJI Shinya wrote:
> > The pg driver quotes it as:
> > 
> > '\'
> Because, dbd_mysql define an own quote method (MySQL's API is used),
> but dbd_postgres does not (Postgres's API dosen't have 'quote').
> 
> Try this patch.(untested)

Sorry to take so long to reply.  The patch solves the '\' problem, but
doesn't escape single quotes.  I had to add a quote method like:

        def quote(value)
          case value
          when String
                "'#{ value.gsub(/\\/){ '\\\\' }.gsub(/'/){ '\\\'' } }'"
          else
                super
          end
        end

That solved the quoting problems for me.

It would be great if someone could apply the patch to Pg.rb, or better
yet, if the ruby-postgres driver could be patched to use the internal
quoting mechanism provided by the postgres client libraries.

Thanks,
-Brad