Re: [Ruby-DBI-devel] Bug in XMLFormatter.textconv?

[Michael N. <mne...@nt...>]

On Sat, May 31, 2003 at 03:41:39PM +0100, Brian Candler wrote:
> Just spotted this in lib/dbi/utils.rb:
> 
>     def textconv(str)
>       str = str.to_s.gsub('&', "&")
>       str = str.gsub('\'', "'")
>       str = str.gsub('\"', "&#34;")     # <<<<<<<<<< here
>       str = str.gsub('<', "&#60;")
>       str.gsub('>', "&#62;")
>     end
> 
> I think that's wrong: it replaces the sequence backslash-doublequote with
> &#34;  - shouldn't it be gsub('"', "&#34;")  ?

That's indeed a bug. Thanks! 

Fixed!


Regards,

  Michael