[Ruby-DBI-devel] Bug in XMLFormatter.textconv?

[Brian C. <B.C...@po...>]

Just spotted this in lib/dbi/utils.rb:

    def textconv(str)
      str = str.to_s.gsub('&', "&")
      str = str.gsub('\'', "'")
      str = str.gsub('\"', "&#34;")     # <<<<<<<<<< here
      str = str.gsub('<', "&#60;")
      str.gsub('>', "&#62;")
    end

I think that's wrong: it replaces the sequence backslash-doublequote with
&#34;  - shouldn't it be gsub('"', "&#34;")  ?

Cheers,

Brian.