Re: Rsyncrypto on Windows Vista

[Shachar S. <sh...@sh...>]

Thomas Constans wrote:
>
>
> 15d14
> < #define S_IFLNK 0120000
> 191,193c190
> <       if( data.dwFileAttributes&FILE_ATTRIBUTE_REPARSE_POINT ) {
> <          ret.st_mode=S_IFLNK;
> <       } else if( data.dwFileAttributes&FILE_ATTRIBUTE_DIRECTORY ) {
> ---
>   
>>         if( data.dwFileAttributes&FILE_ATTRIBUTE_DIRECTORY ) {
>>     
>
>
>   
Okay, thanks for the feedback.

I've committed the change (well, more or less). In the future, please 
keep the following points in mind when you send patches:
- The order in which you compare the files is important. Your patch is 
reversed, which means it will turn a patched version into an unpatched 
version.
- Use unified diff format. For "diff", this is done with -u.
- Use the correct file path. Patches should be made to be applied with 
either -p0 or -p1.
- The easiest way to generate the patch, AND make sure it complies with 
everything i just said, is to use subversion's "diff" command. It is 
also available on Windows through tortoise SVN. This way you know the 
patches you produce are ok.
- If possible, try to attach the patches instead of quoting them inline. 
Try to make sure, however, that your mail client puts them with a MIME 
type that makes the result quoted inline. Thunderbird does that 
automatically for .patch and .diff files.

Shachar