[rox-devel] Re: ROX-Filer 1.1.7 patches

[Thomas L. <ta...@ec...>]

On Tue, Sep 25, 2001 at 03:03:42AM +0200, Bernard Jungen wrote:
> Hi Thomas,
> 
> It's a long time I didn't have time to contribute, so I thought I'll offer
> some patches to include. Here's a summary:
> 
> Disk usage: able to count beyond 4Gb, report number of files and directories.
>             I understand 'long long' may be less portable than 'double'?

Added, although I changed the way the number of directories is reported
for i18n reasons.

> Options: two new options: 'show hidden' and 'inherit options', therefore
>          modified filer_open_dir().

OK, and I've edited run_diritem so middle-clicking and following symlinks
inherits too.

> display.h: removed unused protos.

> support.c: new our_host_name_for_dnd() uses our_host_name(). I hope to have
>            gotten the purpose of that right.

OK.

> main.c and filer.c: new CLI option -c to recursively close windows, therefore
>                     new filer_close_recursive(). Useful when dismounting from
>                     outside rox.

Changed to -D; -c is used for session management.

> some typos in comments fixed.
> 
> minibuffer.c: fix to avoid assertion fail when handling empty Select-If.

Already fixed.

> support.c: changed format_double_size() to be consistant with the others.
> 
> support.h: increased PRETTY_SIZE_LIMIT to maximum 10000.

> new Options.xml and rox.1

OK.

> To do: update the manuals with the 3 new options.

Don't worry about that, I update it before each release. Also, I'm in the
middle of converting to DocBook at the moment...


Thanks, it's good to see you back!


-- 
Thomas Leonard			http://rox.sourceforge.net
ta...@ec...		ta...@us...