Re: [rox-devel] ROX-Menu (was: New Applet)

[Thomas L. <ta...@ec...>]

On Mon, May 14, 2001 at 01:00:07AM -0300, Leandro A. F. Pereira wrote:
> 
> Hi Thomas,

Hi,

[ ROX-Menu ]

> The new version is available at http://www.mindcrisis.com/rox :) Maybe 
> this week I'll finish coding the directory and easy configuration stuff.

Just a few more points ;-)

- You're using a hard-coded setting for Choices instead of reading the 
  CHOICESPATH environment variable. Copy choices.c from ROX-Filer to get
  these functions...

- If any of the default directories (eg /usr/apps) is missing then the
  program crashes - better to just ignore them!

- 'char *buffer[...]' is used in many places - it should be 'char buffer[...]'
  Then you won't need the casts, either...

- Using the glib functions is usually easier and much safer, eg:

	path = g_strdup_printf("%s/AppIcon.xpm", path);

HTH,


-- 
Thomas Leonard			http://rox.sourceforge.net
ta...@ec...		ta...@us...