Re: [rox-devel] ROX-Lib exception dialog

[Thomas L. <ta...@gm...>]

2008/3/1 Tony Houghton <h...@re...>:
> In <cd5...@ma...>
> "Thomas Leonard" <ta...@gm...> wrote:
>> On 29/02/2008, Tony Houghton <h...@re...> wrote:
>> > In <200...@ti...>
>> > Tony Houghton <h...@re...> wrote:
>> >
>> >  > ROX-Lib's exception dialog often fails to work correctly. It
>> >  > appears, but doesn't respond to any events, and neither does the
>> >  > rest of the application. I don't think it always happens, but I
>> >  > haven't figured out the circumstances of when it works and when
>> >  > it doesn't.
>> >
>> > And this patch seems to fix it. AFAICT (I forced an exception and
>> > tried clicking the Details button) there's no problem with using
>> > Dialog.run() repeatedly.
>>
>> Well, the previous patch to touch that code (8c8822a3) did:
>>
>> -               resp = box.run()
>> +               g.mainloop()
>> +               resp = reply.pop()
>
> Well AFAICT (I haven't really got the hang of gitk) it was you who did
> it! Can you remember why?

No, and the log message isn't helpful :-(

OK, I've applied your patch. If it breaks for someone, we can investigate
further then!


-- 
Dr Thomas Leonard	http://rox.sourceforge.net
GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1